[PATCH] Move logic from llvm::Triple::getARMCPUForArch to driver::tools::arm::getARMCPUForMArch

Derek Schuff dschuff at google.com
Thu Mar 26 09:44:05 PDT 2015


The out of line function is on the LLVM side, so that will be a separate commit (http://reviews.llvm.org/D8637)


================
Comment at: lib/Driver/Tools.cpp:5544
@@ -5543,2 +5543,3 @@
 
-  return Triple.getARMCPUForArch(MArch);
+  switch (Triple.getOS()) {
+  case llvm::Triple::FreeBSD:
----------------
rengolin wrote:
> Move this switch inside the identical one below, after the StringSwitch.
I don't think that will work. This logic is supposed to override the StringSwitch; e.g. if the OS is FreeBSD and MArch is "armv6" then the CPU is supposed to be "arm1176jzf-s" but if this switch is moved, then the StringSwitch logic will return "arm1136jf-s"

http://reviews.llvm.org/D8622

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list