[PATCH] [lld][ARM] Handle mapping symbols

Denis Protivensky dprotivensky at accesssoftek.com
Thu Mar 26 00:10:19 PDT 2015


================
Comment at: lib/ReaderWriter/ELF/ARM/ARMELFFile.h:55
@@ -35,1 +54,3 @@
+  bool isThumbFunc() const {
+    const Elf_Sym* symbol = this->_symbol;
     return symbol->getType() == llvm::ELF::STT_FUNC &&
----------------
ruiu wrote:
> remove "this->"
I'd want to, but gcc doesn't resolve template dependent names otherwise.

================
Comment at: lib/ReaderWriter/ELF/ARM/ARMELFFile.h:119
@@ +118,3 @@
+      default:
+      // Fall through and create regular defined atom.
+      break;
----------------
ruiu wrote:
> wrong indentation
Will fix.

http://reviews.llvm.org/D8601

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list