[rfc][patch] Refactoring how we handle symbols for the end of sections

Eric Christopher echristo at gmail.com
Wed Mar 25 16:53:27 PDT 2015


Much nicer, thanks Rafael.

Go ahead for the non-MCSectionELF cases to add a /* !unique */ to the false
operand to MCSection if you wouldn't mind. Otherwise OK.

Thanks!

-eric

On Mon, Mar 23, 2015 at 5:15 PM Rafael EspĂ­ndola <rafael.espindola at gmail.com>
wrote:

> On 23 March 2015 at 17:03, Eric Christopher <echristo at gmail.com> wrote:
> > This is a good improvement.
> >
> > LGTM.
>
> Thanks for the quick review.
>
> Attached is an alternative patch for the rest. It moves the Unique bit
> to MCSection and ensure unique sections are ended when we switch away
> from them.
>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150325/9669f9a9/attachment.html>


More information about the llvm-commits mailing list