[PATCH] [ARM] Mark a bunch of .td Operands with type _MEMORY.

Ahmed Bougacha ahmed.bougacha at gmail.com
Wed Mar 25 15:39:15 PDT 2015


Hi rengolin,

This adds a bunch of OPERAND_MEMORY OperandTypes around the memory operands (addrmode & friends).

I'm pretty sure this can't affect anything in-tree, but not 100%, hence this thread.  This also makes this all pretty much untestable.  The OperandType users are mostly disassemblers and similar tools;  more information is helpful for those.

Some of the PC-relative things, I'm on the fence (e.g. addrmodepc, t2adrlabel, t_adrlabel, and the various *ld*pcrel*).  OPERAND_PCREL sounds better, but in practice, I know some OperandType users interpret "PCREL" as labels and other code-related pointers, so OPERAND_MEMORY is more suitable, really.  Basically, the names are a tad misleading.

Thanks!
-Ahmed

http://reviews.llvm.org/D8620

Files:
  lib/Target/ARM/ARMInstrInfo.td
  lib/Target/ARM/ARMInstrThumb.td
  lib/Target/ARM/ARMInstrThumb2.td

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D8620.22683.patch
Type: text/x-patch
Size: 15227 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150325/fb7ac6f2/attachment.bin>


More information about the llvm-commits mailing list