[PATCH] CMake: enable installing utils

Mircea Trofin mtrofin at google.com
Wed Mar 25 14:23:16 PDT 2015


I see. I didn't fully grasp that nuance, thanks for clarifying!

On Wed, Mar 25, 2015 at 2:14 PM Chris Bieneman <beanz at apple.com> wrote:

> ================
> Comment at: cmake/modules/AddLLVM.cmake:554
> @@ +553,3 @@
> +      COMPONENT ${name})
> +    add_custom_target(install-${name}
> +                      DEPENDS ${name}
> ----------------
> Sorry to nitpick, but you want to wrap this in:
>
> if (NOT CMAKE_CONFIGURATION_TYPES)
>
> That way you won't be creating an unwieldy number of extra targets for IDE
> users.
>
> http://reviews.llvm.org/D8587
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150325/ad22b8ae/attachment.html>


More information about the llvm-commits mailing list