[llvm] r233206 - [Hexagon] Keep the bare getSubtargetImpl for now

Krzysztof Parzyszek kparzysz at codeaurora.org
Wed Mar 25 13:14:47 PDT 2015


We use it in many places in our local code (the one that is not yet 
upstreamed).  We regularly integrate the changes from llvm.org and 
removing the bare subtarget function would make this integration very 
painful. I added it back for now until we get the migration done. We do 
plan to upstream our code, but the efforts are only now getting more 
traction.

-Krzysztof


On 3/25/2015 2:59 PM, Eric Christopher wrote:
> Why? You don't use it.
>
> -eric
>
> On Wed, Mar 25, 2015 at 12:56 PM Krzysztof Parzyszek
> <kparzysz at codeaurora.org <mailto:kparzysz at codeaurora.org>> wrote:
>
>     Author: kparzysz
>     Date: Wed Mar 25 14:51:52 2015
>     New Revision: 233206
>
>     URL: http://llvm.org/viewvc/llvm-__project?rev=233206&view=rev
>     <http://llvm.org/viewvc/llvm-project?rev=233206&view=rev>
>     Log:
>     [Hexagon] Keep the bare getSubtargetImpl for now
>
>     Modified:
>          llvm/trunk/lib/Target/Hexagon/__HexagonTargetMachine.h
>
>     Modified: llvm/trunk/lib/Target/Hexagon/__HexagonTargetMachine.h
>     URL:
>     http://llvm.org/viewvc/llvm-__project/llvm/trunk/lib/Target/__Hexagon/HexagonTargetMachine.__h?rev=233206&r1=233205&r2=__233206&view=diff
>     <http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Hexagon/HexagonTargetMachine.h?rev=233206&r1=233205&r2=233206&view=diff>
>     ==============================__==============================__==================
>     --- llvm/trunk/lib/Target/Hexagon/__HexagonTargetMachine.h (original)
>     +++ llvm/trunk/lib/Target/Hexagon/__HexagonTargetMachine.h Wed Mar
>     25 14:51:52 2015
>     @@ -32,6 +32,9 @@ public:
>                              Reloc::Model RM, CodeModel::Model CM,
>                              CodeGenOpt::Level OL);
>         ~HexagonTargetMachine() override;
>     +  const HexagonSubtarget *getSubtargetImpl() const {
>     +    return &Subtarget;
>     +  }
>         const HexagonSubtarget *getSubtargetImpl(const Function &) const
>     override {
>           return &Subtarget;
>         }
>
>
>     _________________________________________________
>     llvm-commits mailing list
>     llvm-commits at cs.uiuc.edu <mailto:llvm-commits at cs.uiuc.edu>
>     http://lists.cs.uiuc.edu/__mailman/listinfo/llvm-commits
>     <http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits>
>


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, 
hosted by The Linux Foundation



More information about the llvm-commits mailing list