[PATCH] [X86][FastIsel] Teach how to select vector load instructions.

[Andrea Di Biagio]

================
Comment at: lib/Target/X86/X86FastISel.cpp:331
@@ -331,1 +330,3 @@
+                                  MachineMemOperand *MMO, unsigned &ResultReg,
+                                  bool Aligned) {
   // Get opcode and regclass of the output for the given load instruction.
----------------
qcolombet wrote:
> Instead of passing a bool, I think the actual alignment we saw may be useful.
> We could imagine that we generate different instructions based on the value of that alignment.
> 
> That being said, this is not the case right now, so we can adjust accordingly later. It just feel weird that the callers know about the required alignments.
> 
> What do you think?
Right, I agree with you; it feels wrong that the caller sets the 'Aligned' flag without knowing which opcode will be selected for the load instruction.
I am going to replace 'bool Aligned' we 'unsigned Alignment'. I will then change the logic inside this method so that an 'aligned' load is selected only if Alignment is != 16.

Thanks!

http://reviews.llvm.org/D8605

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/