[PATCH] [lld][ARM] Handle mapping symbols
Rui Ueyama
ruiu at google.com
Wed Mar 25 11:00:57 PDT 2015
LGTM
================
Comment at: lib/ReaderWriter/ELF/ARM/ARMELFFile.h:55
@@ -35,1 +54,3 @@
+ bool isThumbFunc() const {
+ const Elf_Sym* symbol = this->_symbol;
return symbol->getType() == llvm::ELF::STT_FUNC &&
----------------
remove "this->"
================
Comment at: lib/ReaderWriter/ELF/ARM/ARMELFFile.h:63
@@ +62,3 @@
+ uint64_t getSymbolValue() const override {
+ const auto value = static_cast<uint64_t>(this->_symbol->st_value);
+ return isThumbFunc() ? value & ~0x1 : value;
----------------
Ditto
================
Comment at: lib/ReaderWriter/ELF/ARM/ARMELFFile.h:119
@@ +118,3 @@
+ default:
+ // Fall through and create regular defined atom.
+ break;
----------------
wrong indentation
http://reviews.llvm.org/D8601
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list