[PATCH] DebugInfo: Permit DW_TAG_structure_type, DW_TAG_member, DW_TAG_typedef tags with empty file names.

Peter Collingbourne peter at pcc.me.uk
Wed Mar 25 10:47:38 PDT 2015


REPOSITORY
  rL LLVM

================
Comment at: test/DebugInfo/X86/missing-file-line.ll:3
@@ +2,3 @@
+
+; RUN: llc -mtriple=x86_64-linux-gnu -filetype=obj %s -o - | llvm-dwarfdump -debug-dump=all - > %t
+; RUN: FileCheck --check-prefix=CHECK1 %s < %t
----------------
dblaikie wrote:
> Ideally just pipe dwarfdump's output straight to FileCheck without the intermediate %t - then just use a single set of CHECK (rather than 3 separate CHECK prefixes) lines for the tests.
Previously I used `CHECK-DAG`, but I couldn't see a way to do the `CHECK-NOT` checks within a single run of FileCheck while keeping them order independent.

================
Comment at: test/DebugInfo/X86/missing-file-line.ll:22
@@ +21,3 @@
+  ; CHECK1-NOT: DW_AT_decl_line
+  ; CHECK1: {{^0x}}
+
----------------
probinson wrote:
> I see why this works, but we usually check DW_TAG|NULL to constrain the range to a single DIE.  Ditto for the other two places.
Done

http://reviews.llvm.org/D8588

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list