[llvm] r233165 - Linker: Temporarily disable dwarfdump checks from r233164

[Duncan P. N. Exon Smith]

> On 2015-Mar-25, at 10:12, Duncan P. N. Exon Smith <dexonsmith at apple.com> wrote:
> 
> Good point, I guess I'm not being very creative :/.  Peter also obliged
> [1] my request for a dump on Linux, which I've reproduced locally by
> specifying -mtriple=x86_64-unknown-linux.  What's going wrong is the
> second compile unit is missing the subprogram for the weak ("winning")
> function.
> 
> [1]: https://llvm.org/bugs/show_bug.cgi?id=22792#c7 "Output on Linux"
> 
> This DWARF is wrong, right?  (I.e., are the expected differences in
> debug info between Linux and Darwin all in the frontend generation
> logic?)

Just talked to Adrian offline; answer is "yes".  I'll see if I can figure
this out and just revert r233165.

> 
>> On 2015-Mar-25, at 09:47, Eric Christopher <echristo at gmail.com> wrote:
>> 
>> There's nothing linux specific in the test that I can tell from a quick glance. You should be able to reproduce the behavior locally by using a triple when doing llc?
>> 
>> -eric
>> 
>> On Wed, Mar 25, 2015 at 9:44 AM Duncan P. N. Exon Smith <dexonsmith at apple.com> wrote:
>> I was thinking overnight about the best way to re-enable this for
>> Darwin/Mach-O, since I don't think I can put target-specific tests in
>> test/Linker.
>> 
>> I'm planning to duplicate the test over to test/LTO/X86.  I'll use the
>> merged IR CHECKs only in test/Linker, and use the DWARF CHECKs only in
>> test/LTO/X86.  In both cases, I'll use the original (unmerged) IR files
>> as input.  (Testing from the merged IR in test/LTO/X86 seems like a bad
>> option, since if/when we change what the correct merged result is, the
>> testcase won't be interesting anymore.)
>> 
>> Does this sound reasonable?
>> 
>>> On 2015-Mar-25, at 08:23, Rafael Espíndola <rafael.espindola at gmail.com> wrote:
>>> 
>>> Can you add an explicit triple to llc instead? That way we keep the
>>> test going with MachO at least.
>>> 
>>> On 24 March 2015 at 22:43, Duncan P. N. Exon Smith <dexonsmith at apple.com> wrote:
>>>> Author: dexonsmith
>>>> Date: Tue Mar 24 21:43:04 2015
>>>> New Revision: 233165
>>>> 
>>>> URL: http://llvm.org/viewvc/llvm-project?rev=233165&view=rev
>>>> Log:
>>>> Linker: Temporarily disable dwarfdump checks from r233164
>>>> 
>>>> At least one Linux bot [1] doesn't like my dwarfdump checks, so I've
>>>> disable those until I can investigate what's going on there.  I'll
>>>> continue to track this in PR22792.
>>>> 
>>>> [1]: http://bb.pgr.jp/builders/cmake-llvm-x86_64-linux/builds/22863
>>>> 
>>>> Modified:
>>>>   llvm/trunk/test/Linker/subprogram-linkonce-weak.ll
>>>> 
>>>> Modified: llvm/trunk/test/Linker/subprogram-linkonce-weak.ll
>>>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Linker/subprogram-linkonce-weak.ll?rev=233165&r1=233164&r2=233165&view=diff
>>>> ==============================================================================
>>>> --- llvm/trunk/test/Linker/subprogram-linkonce-weak.ll (original)
>>>> +++ llvm/trunk/test/Linker/subprogram-linkonce-weak.ll Tue Mar 24 21:43:04 2015
>>>> @@ -96,9 +96,12 @@ entry:
>>>> ; Crasher for llc.
>>>> ; REQUIRES: object-emission
>>>> ; RUN: %llc_dwarf -filetype=obj -O0 %t1 -o %t1.o
>>>> -; RUN: llvm-dwarfdump %t1.o -debug-dump=info | FileCheck %s -check-prefix=DWLW
>>>> +; RUNDISABLED: llvm-dwarfdump %t1.o -debug-dump=info | FileCheck %s -check-prefix=DWLW
>>>> ; RUN: %llc_dwarf -filetype=obj -O0 %t2 -o %t2.o
>>>> -; RUN: llvm-dwarfdump %t2.o -debug-dump=info | FileCheck %s -check-prefix=DWWL
>>>> +; RUNDISABLED: llvm-dwarfdump %t2.o -debug-dump=info | FileCheck %s -check-prefix=DWWL
>>>> +; Getting different dwarfdump output on different platforms, so I've
>>>> +; temporarily disabled the Dwarf FileChecks while leaving in the crash tests.
>>>> +; I'll keep using PR22792 to track this.
>>>> 
>>>> ; DWLW:     DW_TAG_compile_unit
>>>> ; DWLW:       DW_AT_name {{.*}}"bar.c"
>>>> 
>>>> 
>>>> _______________________________________________
>>>> llvm-commits mailing list
>>>> llvm-commits at cs.uiuc.edu
>>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits