[PATCH] MC: For variable symbols, maintain MCSymbol::Section as a cache.

Jim Grosbach grosbach at apple.com
Tue Mar 24 15:43:18 PDT 2015


There's not enough information in the description for me to go on. Which edge cases? How/why were they wrong before?

For example, the fact that this patch changes the results in the MachO test concerns me. Why are the old values incorrect and the new ones correct? The first two changes look like it's a difference in order of what's in the object file, which is probably fine, but alias_to_local refers to __data now where before it did not. Why?


http://reviews.llvm.org/D8586

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list