[PATCH] Default to armv7 cpu for NaCl when march=arm

[Derek Schuff]

replies inline but see earlier general comment


================
Comment at: lib/Support/Triple.cpp:1078
@@ +1077,3 @@
+  case llvm::Triple::NaCl:
+    if (MArch == "arm")
+      return "cortex-a9";
----------------
rengolin wrote:
> That's unnecessary, since this is an ARM-only function.
I think it is what I want because if the user specifies something other than plain "arm" it should override this default.

================
Comment at: lib/Support/Triple.cpp:1079
@@ +1078,3 @@
+    if (MArch == "arm")
+      return "cortex-a9";
+    break;
----------------
rengolin wrote:
> And cortex-a9 is not the best choice for almost anything. The base ARMv7 is Cortex-A8, and most NaCl devices will probably be running on Cortex-A15.
OK, noted.
All NaCl devices that I'm aware of are A15 but the base requirement for NaCl is specified as v7 + NEON.

http://reviews.llvm.org/D8589

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/