[PATCH] xfail tests that failed with clang-3.7, gcc4.8.2 and on i386 to get buildbot green

[Siva Chandra]

My comments are not just for the author, but also for other reviewers on this change.


================
Comment at: test/functionalities/data-formatter/data-formatter-stl/libstdcpp/vbool/TestDataFormatterStdVBool.py:27
@@ -26,2 +26,3 @@
     @skipIfDarwin
+    @expectedFailurei386 #xfail to get buildbot green, test fails on ubuntu x86_64
     def test_with_dwarf_and_run_command(self):
----------------
This and similar comments attached to expectedFailurei386 below are confusing. Perhaps s/x86_64/i386 ? Even then, seems redundant.

Another note: Tamas has a fix for this approved. He might land it any time soon. So, may be observe the bot after his fix lands and take out the xfail decorator if the test starts passing?

================
Comment at: test/lang/cpp/this/TestCPPThis.py:25
@@ -24,2 +24,3 @@
     @dwarf_test
+    @expectedFailureClang(bugnumber='19893563', compiler_version=['>=','3.6'])#xfail to get buildbot green, test failed with totclang - clang3.7
     def test_with_dwarf_and_run_command(self):
----------------
Why do we have a bug number only for this? Also, seems like the right tracking bug number is 19893491.

Unrelated: If we should be putting internal bug numbers at all, could we just put http://b/<bugnumber> similar to how apple puts links to rdar bugs?

http://reviews.llvm.org/D8573

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/