[PATCH] [mips] [IAS] Improve warning for using AT with .set noat.

[Daniel Sanders]

LGTM with a couple nits.

One other nit is the use of 'aka $n'. I'm not sure we should use 'aka' since $at can be reassigned as we process the assembly. Maybe 'currently $n' instead?


================
Comment at: test/MC/Mips/set-at-directive-explicit-at.s:30
@@ -27,3 +29,3 @@
     jr    $1
-# WARNINGS-NOT: warning: used $at without ".set noat"
+# WARNINGS-NOT: warning: used $at (aka $1) without ".set noat"
 
----------------
tomatabacu wrote:
> I'm not sure if this CHECK is necessary.
It is necessary but it's slightly wrong at the moment. It used to check that warnings weren't emitted by lines 34, 37, and 43. You need to change '$1' to '${{[0-9]+}'

================
Comment at: test/MC/Mips/set-at-directive-explicit-at.s:54
@@ -51,2 +53,2 @@
     jr    $16
 # WARNINGS-NOT: warning
----------------
tomatabacu wrote:
> I'm not sure if this CHECK is necessary, either.
I agree

http://reviews.llvm.org/D8479

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/