[PATCH] [AArch64] Add v8.1a "Privileged Access Never" extension

James Molloy james.molloy at arm.com
Tue Mar 24 03:18:13 PDT 2015


Hi Vladimir,

With the above nits picked, looks fine to me!

Cheers,

James


REPOSITORY
  rL LLVM

================
Comment at: lib/Target/AArch64/Utils/AArch64BaseInfo.h:446
@@ -446,1 +445,3 @@
+    DAIFClr = 0x1f,
+    PAN = 0x04,
   };
----------------
Please add a comment like "// Added in v8.1a", to signify why PAN is out of numeric order.

================
Comment at: test/MC/AArch64/armv8-extension-pan.s:1
@@ +1,2 @@
+//RUN: not llvm-mc -triple aarch64-none-linux-gnu -mattr=+v8.1a -show-encoding < %s 2> %t | FileCheck %s
+//RUN: FileCheck --check-prefix=CHECK-ERROR %s < %t
----------------
I know it's picky, but please add a space after the // like all other files.

http://reviews.llvm.org/D8498

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list