[PATCH] Make getLastArgNoClaim work for up to 4 arguments.
Paul Robinson
Paul_Robinson at playstation.sony.com
Mon Mar 23 21:19:13 PDT 2015
In http://reviews.llvm.org/D8508#145721, @silvas wrote:
> In http://reviews.llvm.org/D8508#144677, @probinson wrote:
>
> > In http://reviews.llvm.org/D8508#144526, @Bigcheese wrote:
> >
> > > Why not make this a variadic template?
> >
> >
> > A variadic "matches" method on Option would keep it from being
> > amazingly inefficient. (i.e. don't iterate through ArgList N times.)
>
>
> The real solution is to not have to walk the list for every method call like this. I.e. use a data structure that efficiently supports these sorts of queries.
Well, sure. I just didn't want Michael's comment to prompt an inductive template on getLastArg, which would be worse.
REPOSITORY
rL LLVM
http://reviews.llvm.org/D8508
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list