[llvm] r232944 - Move private classes into anonymous namespaces

Rafael EspĂ­ndola rafael.espindola at gmail.com
Mon Mar 23 17:46:23 PDT 2015


Thanks a lot for all these fixes. Do you have a script to hunt down
unnecessary symbols?
On Mar 23, 2015 8:35 AM, "Benjamin Kramer" <benny.kra at googlemail.com> wrote:

> Author: d0k
> Date: Mon Mar 23 07:30:58 2015
> New Revision: 232944
>
> URL: http://llvm.org/viewvc/llvm-project?rev=232944&view=rev
> Log:
> Move private classes into anonymous namespaces
>
> NFC.
>
> Modified:
>     llvm/trunk/lib/CodeGen/LiveInterval.cpp
>     llvm/trunk/lib/CodeGen/RegisterPressure.cpp
>     llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
>     llvm/trunk/lib/Support/GraphWriter.cpp
>     llvm/trunk/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp
>     llvm/trunk/lib/Transforms/Scalar/LoopUnrollPass.cpp
>
> Modified: llvm/trunk/lib/CodeGen/LiveInterval.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/LiveInterval.cpp?rev=232944&r1=232943&r2=232944&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/CodeGen/LiveInterval.cpp (original)
> +++ llvm/trunk/lib/CodeGen/LiveInterval.cpp Mon Mar 23 07:30:58 2015
> @@ -32,6 +32,7 @@
>  #include <algorithm>
>  using namespace llvm;
>
> +namespace {
>
>  //===----------------------------------------------------------------------===//
>  // Implementation of various methods necessary for calculation of live
> ranges.
>  // The implementation of the methods abstracts from the concrete type of
> the
> @@ -293,6 +294,7 @@ private:
>      return I;
>    }
>  };
> +} // namespace
>
>
>  //===----------------------------------------------------------------------===//
>  //   LiveRange methods
>
> Modified: llvm/trunk/lib/CodeGen/RegisterPressure.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/RegisterPressure.cpp?rev=232944&r1=232943&r2=232944&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/CodeGen/RegisterPressure.cpp (original)
> +++ llvm/trunk/lib/CodeGen/RegisterPressure.cpp Mon Mar 23 07:30:58 2015
> @@ -304,6 +304,7 @@ static bool containsReg(ArrayRef<unsigne
>    return std::find(RegUnits.begin(), RegUnits.end(), RegUnit) !=
> RegUnits.end();
>  }
>
> +namespace {
>  /// Collect this instruction's unique uses and defs into SmallVectors for
>  /// processing defs and uses in order.
>  ///
> @@ -354,6 +355,7 @@ protected:
>      }
>    }
>  };
> +} // namespace
>
>  /// Collect physical and virtual register operands.
>  static void collectOperands(const MachineInstr *MI,
>
> Modified: llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp?rev=232944&r1=232943&r2=232944&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp (original)
> +++ llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp Mon Mar 23
> 07:30:58 2015
> @@ -9984,6 +9984,7 @@ SDValue DAGCombiner::TransformFPLoadStor
>    return SDValue();
>  }
>
> +namespace {
>  /// Helper struct to parse and store a memory address as base + index +
> offset.
>  /// We ignore sign extensions when it is safe to do so.
>  /// The following two expressions are not equivalent. To differentiate we
> need
> @@ -10071,6 +10072,7 @@ struct BaseIndexOffset {
>      return BaseIndexOffset(Base, Index, Off, IsIndexSignExt);
>    }
>  };
> +} // namespace
>
>  bool DAGCombiner::MergeStoresOfConstantsOrVecElts(
>                    SmallVectorImpl<MemOpLink> &StoreNodes, EVT MemVT,
>
> Modified: llvm/trunk/lib/Support/GraphWriter.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/GraphWriter.cpp?rev=232944&r1=232943&r2=232944&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/Support/GraphWriter.cpp (original)
> +++ llvm/trunk/lib/Support/GraphWriter.cpp Mon Mar 23 07:30:58 2015
> @@ -98,6 +98,7 @@ static bool ExecGraphViewer(StringRef Ex
>    return false;
>  }
>
> +namespace {
>  struct GraphSession {
>    std::string LogBuffer;
>    bool TryFindProgram(StringRef Names, std::string &ProgramPath) {
> @@ -114,6 +115,7 @@ struct GraphSession {
>      return false;
>    }
>  };
> +} // namespace
>
>  static const char *getProgramName(GraphProgram::Name program) {
>    switch (program) {
>
> Modified: llvm/trunk/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp?rev=232944&r1=232943&r2=232944&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp (original)
> +++ llvm/trunk/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp Mon Mar 23
> 07:30:58 2015
> @@ -1143,6 +1143,7 @@ SDNode *AArch64DAGToDAGISel::SelectPostS
>    return St;
>  }
>
> +namespace {
>  /// WidenVector - Given a value in the V64 register class, produce the
>  /// equivalent value in the V128 register class.
>  class WidenVector {
> @@ -1163,6 +1164,7 @@ public:
>      return DAG.getTargetInsertSubreg(AArch64::dsub, DL, WideTy, Undef,
> V64Reg);
>    }
>  };
> +} // namespace
>
>  /// NarrowVector - Given a value in the V128 register class, produce the
>  /// equivalent value in the V64 register class.
>
> Modified: llvm/trunk/lib/Transforms/Scalar/LoopUnrollPass.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/LoopUnrollPass.cpp?rev=232944&r1=232943&r2=232944&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/Transforms/Scalar/LoopUnrollPass.cpp (original)
> +++ llvm/trunk/lib/Transforms/Scalar/LoopUnrollPass.cpp Mon Mar 23
> 07:30:58 2015
> @@ -259,6 +259,7 @@ static bool isLoadFromConstantInitialize
>    return false;
>  }
>
> +namespace {
>  struct FindConstantPointers {
>    bool LoadCanBeConstantFolded;
>    bool IndexIsConstant;
> @@ -541,6 +542,7 @@ public:
>      return NumberOfOptimizedInstructions;
>    }
>  };
> +} // namespace
>
>  // Complete loop unrolling can make some loads constant, and we need to
> know if
>  // that would expose any further optimization opportunities.
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150323/f95ff8e3/attachment.html>


More information about the llvm-commits mailing list