[PATCH] Set a debugger "target" to guide DWARF choices
Paul Robinson
Paul_Robinson at playstation.sony.com
Mon Mar 23 13:30:20 PDT 2015
================
Comment at: lib/CodeGen/AsmPrinter/DwarfDebug.cpp:210
@@ +209,3 @@
+ bool IsPS4 = Triple(A->getTargetTriple()).isPS4CPU();
+ Asm->TM.Options.Debugger = IsPS4 ? DebuggerKind::SCE : DebuggerKind::GDB;
+ }
----------------
Should this set LLDB for Darwin? I wasn't sure.
================
Comment at: lib/CodeGen/AsmPrinter/DwarfDebug.cpp:236
@@ -230,3 +235,3 @@
// Everybody else uses GNU's.
- UseGNUTLSOpcode = !(IsDarwin || IsPS4) || DwarfVersion < 3;
+ UseGNUTLSOpcode = !(IsDarwin || isDebuggerSCE()) || DwarfVersion < 3;
----------------
aprantl wrote:
> This should probably be IsDebuggerLLDB() instead of IsDarwin.
OK.
http://reviews.llvm.org/D8506
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list