[PATCH] Add LLVM support for remaining integer divide and permute instructions from ISA 2.06

[Bill Schmidt]

Hi Nemanja,

Sorry to be a pain, but I don't support FeatureISA206 / FeatureISA207.  See inline comment. :/  Hal, your thoughts?

Bill


REPOSITORY
  rL LLVM

================
Comment at: lib/Target/PowerPC/PPC.td:163
@@ +162,3 @@
+def ProcessorFeatures {
+  list<SubtargetFeature> Power7FeatureList =
+      [FeatureISA206, DirectivePwr7, FeatureAltivec, FeatureVSX,
----------------
I don't care for the FeatureISA206 choice.  It contradicts the existing design (there are plenty of features called out that are also in ISA 2.06, so why is this one special?), and is redundant with Power7FeatureList (if you have a Power7FeatureList, shouldn't it just be previous features + FeatureISA206 under this philosophy?).

I think you should go back to Hal's suggestion and provide relevant features that are grouped in a reasonable way.  For this patch, that would be something like FeatureExtDiv and FeatureBitPerm.  I don't think we have a need to disrupt the existing design.

http://reviews.llvm.org/D8406

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/