[PATCH] Refactor: Simplify boolean expressions in ARM target
Renato Golin
renato.golin at linaro.org
Sun Mar 22 14:07:59 PDT 2015
Looks good with the comment, thanks!
================
Comment at: lib/Target/ARM/AsmParser/ARMAsmParser.cpp:5421
@@ -5420,3 +5420,3 @@
bool &CanAcceptCarrySet, bool &CanAcceptPredicationCode) {
- if (Mnemonic == "and" || Mnemonic == "lsl" || Mnemonic == "lsr" ||
+ CanAcceptCarrySet = Mnemonic == "and" || Mnemonic == "lsl" || Mnemonic == "lsr" ||
Mnemonic == "rrx" || Mnemonic == "ror" || Mnemonic == "sub" ||
----------------
Nitpick, maybe keep the Mnemonic on the next line, so it continues to align with the others.
http://reviews.llvm.org/D8524
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list