[PATCH] R600/SI: Fix crash in SIInstrInfo::areLoadsFromSameBasePtr()

Tom Stellard tom at stellard.net
Fri Mar 20 18:39:16 PDT 2015


On Fri, Mar 20, 2015 at 06:27:35PM -0700, Matt Arsenault wrote:
> 
> > On Mar 20, 2015, at 5:15 PM, Tom Stellard <thomas.stellard at amd.com> wrote:
> > 
> > This function assumed that SMRD instructions always have immediate
> > offsets, which is not always the case.
> > ---
> > lib/Target/R600/SIInstrInfo.cpp                | 12 +++++++--
> > test/CodeGen/R600/schedule-kernel-arg-loads.ll | 35 ++++++++++++++++++++++++--
> > 2 files changed, 43 insertions(+), 4 deletions(-)
> > 
> 
> LGTM. How did you run into this? I thought this was dead code since the mi scheduler was enabled
> 

The DAGScheduler still runs.  Enabling the mi scheduler just changes the
strategy to source.

-Tom

> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits



More information about the llvm-commits mailing list