[PATCH] [mips] [IAS] Rename MipsAssemblerOptions::getATRegNum to getATReg. NFC.

Toma Tabacu toma.tabacu at imgtec.com
Fri Mar 20 05:29:06 PDT 2015


Hi dsanders,

It would be nice to have symmetry with MipsAssemblerOptions::setATReg.
Depends on http://reviews.llvm.org/D8478.

http://reviews.llvm.org/D8480

Files:
  lib/Target/Mips/AsmParser/MipsAsmParser.cpp

Index: lib/Target/Mips/AsmParser/MipsAsmParser.cpp
===================================================================
--- lib/Target/Mips/AsmParser/MipsAsmParser.cpp
+++ lib/Target/Mips/AsmParser/MipsAsmParser.cpp
@@ -46,13 +46,13 @@
     ATReg(1), Reorder(true), Macro(true), Features(Features_) {}
 
   MipsAssemblerOptions(const MipsAssemblerOptions *Opts) {
-    ATReg = Opts->getATRegNum();
+    ATReg = Opts->getATReg();
     Reorder = Opts->isReorder();
     Macro = Opts->isMacro();
     Features = Opts->getFeatures();
   }
 
-  unsigned getATRegNum() const { return ATReg; }
+  unsigned getATReg() const { return ATReg; }
   bool setATReg(unsigned Reg);
 
   bool isReorder() const { return Reorder; }
@@ -2048,7 +2048,7 @@
     if (!isATAvailable(IDLoc))
       return;
 
-    unsigned AT = AssemblerOptions.back()->getATRegNum();
+    unsigned AT = AssemblerOptions.back()->getATReg();
     TmpRegNum = getReg(
         (isGP64bit()) ? Mips::GPR64RegClassID : Mips::GPR32RegClassID, AT);
   }
@@ -2199,7 +2199,7 @@
 
 bool MipsAsmParser::isATAvailable(SMLoc IDLoc) {
   // If AT is not available, give an error.
-  if (AssemblerOptions.back()->getATRegNum() == 0) {
+  if (AssemblerOptions.back()->getATReg() == 0) {
     reportParseError(
         IDLoc, "pseudo-instruction requires $at, which is not available");
     return false;
@@ -2209,7 +2209,7 @@
 
 void MipsAsmParser::warnIfAssemblerTemporary(int RegIndex, SMLoc Loc) {
   if ((RegIndex != 0) && 
-      ((int)AssemblerOptions.back()->getATRegNum() == RegIndex)) {
+      ((int)AssemblerOptions.back()->getATReg() == RegIndex)) {
     if (RegIndex == 1)
       Warning(Loc, "used $at without \".set noat\"");
     else

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D8480.22341.patch
Type: text/x-patch
Size: 1694 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150320/161b8292/attachment.bin>


More information about the llvm-commits mailing list