[llvm] r232697 - SelectionDAGBuilder: update comment in HandlePHINodesInSuccessorBlocks.
Hans Wennborg
hans at hanshq.net
Wed Mar 18 17:57:51 PDT 2015
Author: hans
Date: Wed Mar 18 19:57:51 2015
New Revision: 232697
URL: http://llvm.org/viewvc/llvm-project?rev=232697&view=rev
Log:
SelectionDAGBuilder: update comment in HandlePHINodesInSuccessorBlocks.
>From what I can tell, the code is checking for PHIs that expect any value from
this block, not just constants.
Modified:
llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
Modified: llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp?rev=232697&r1=232696&r2=232697&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp (original)
+++ llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp Wed Mar 18 19:57:51 2015
@@ -7737,8 +7737,8 @@ SelectionDAGBuilder::HandlePHINodesInSuc
SmallPtrSet<MachineBasicBlock *, 4> SuccsHandled;
- // Check successor nodes' PHI nodes that expect a constant to be available
- // from this block.
+ // Check PHI nodes in successors that expect a value to be available from this
+ // block.
for (unsigned succ = 0, e = TI->getNumSuccessors(); succ != e; ++succ) {
const BasicBlock *SuccBB = TI->getSuccessor(succ);
if (!isa<PHINode>(SuccBB->begin())) continue;
More information about the llvm-commits
mailing list