[PATCH] [Tablegen] Attempt to add support for patterns containing nodes with multiple results.

Craig Topper craig.topper at gmail.com
Wed Mar 18 09:38:39 PDT 2015


But it's not really ignored. At the end of isel we have an SDNode with 2 results and those results need types.

Today that IMPLICIT_DEF got a type of i1 because this code triggered

  if (!IterateInference && InferredAllPatternTypes &&
      !InferredAllResultTypes)
    IterateInference =
        ForceArbitraryInstResultType(Result.getTree(0), Result);

but based on the comment above that code I don't think this case was what that code was intended for. I guess this part of that comment applies for this case "output patterns should have register classes, not MVTs". Maybe I should force an arbitrary result type on extra results that don't show up in the original pattern?


http://reviews.llvm.org/D8373

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list