[PATCH] [Hexagon] Handle ENDLOOP0 in InsertBranch and RemoveBranch

Daniel Jasper djasper at google.com
Wed Mar 18 09:03:28 PDT 2015


Minor style comment. Otherwise looks good.


REPOSITORY
  rL LLVM

================
Comment at: lib/Target/Hexagon/HexagonInstrInfo.cpp:326-329
@@ +325,6 @@
+  switch (Opc1) {
+    case Hexagon::J2_jump:
+    case Hexagon::J2_jumpt:
+    case Hexagon::J2_jumpf:
+    case Hexagon::ENDLOOP0:
+      I->eraseFromParent();
----------------
LLVM style generally does not indent the case labels.

Do you think that these switches are really more readable? They seem a lot longer...

http://reviews.llvm.org/D8418

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list