[PATCH] Add getSizeInBits function to the APFloat class

Tamas Berghammer tberghammer at google.com
Wed Mar 18 08:26:39 PDT 2015


================
Comment at: lib/Support/APFloat.cpp:3374
@@ +3373,3 @@
+  if (&Sem == (const llvm::fltSemantics*)&IEEEhalf)
+    return 16;
+
----------------
hfinkel wrote:
> Why not just add this number to the fltSemantics structure itself?
> 
I think it is not really part of the semantic, but I can move it to there if you want.
If I move it into the semantic then what should be the size value of calcSemantic in roundSignificandWithExponent? It isn't used by anybody (yet) but we still should give it a reasonable value.

http://reviews.llvm.org/D8413

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list