[PATCH] Replace the bitfield of SubtargetFeatures with a BitVector

Vladimir Sukharev vladimir.sukharev at arm.com
Wed Mar 18 07:48:58 PDT 2015


Hi, 
my investigations finally showed AArch64 backend doesn't have a bug.
At it's been told, it's a huge mess instead. The following field and methods mean completely different things in classes MCTargetAsmParser and MCInstPrinter, despite the spelling are identical.

  uint64_t AvailableFeatures; and
  uint64_t getAvailableFeatures(); void setAvailableFeatures(uint64_t Value);

We should just take care, which one to use. It will be simpler after the refactoring proposed here.
Do you have any success continuing this so much needed work in other backends after revert?


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D7065

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list