[llvm] r232513 - [ARM] Fix offset calculation in ARMBaseRegisterInfo::needsFrameBaseReg

Renato Golin renato.golin at linaro.org
Tue Mar 17 13:56:07 PDT 2015


On 17 March 2015 at 19:48, Joerg Sonnenberger <joerg at britannica.bec.de> wrote:
>> [ARM] Fix offset calculation in ARMBaseRegisterInfo::needsFrameBaseReg
>>
>> The input offset to needsFrameBaseReg is a negative value below the top of the
>> stack frame, but when converting to a positive offset from the bottom of the
>> stack frame this value was negated, causing the final offset to be too large
>> by twice the input offset's magnitude. Fix that by not negating the offset.
>
> Should this be merged into the 3.6 branch?

Hi Joerg,

Good point, I think this is a nasty one and should be included. Richard?

cheers,
--renato



More information about the llvm-commits mailing list