[PATCH] [Core] Update references in parallel
Davide Italiano
davide at freebsd.org
Tue Mar 17 13:25:16 PDT 2015
REPOSITORY
rL LLVM
================
Comment at: lib/Core/Resolver.cpp:355
@@ -353,3 +354,3 @@
if (_symbolTable.isCoalescedAway(atom))
_deadAtoms.insert(ref->target());
continue;
----------------
ruiu wrote:
> I think this change is not thread-safe because of this line. _deadAtoms.insert is not thread-safe.
Oh this is really a bummer, considering it's such an hot codepath :(
Do you think it makes sense to surround insert with a lock and measure again and/or do you have a proposal for an alternative?
http://reviews.llvm.org/D8372
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list