Looks good as far as I'm concerned. You might want to do the global variable handling as a separate patch. REPOSITORY rL LLVM http://reviews.llvm.org/D7908 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/