Outside of everything else in the review: please run clang-format over the code you want to add. Too many coding style issues to call them all out in the first pass :) -eric http://reviews.llvm.org/D8371 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/