[PATCH] Verifier: Set --verify-debug-info=true by default

Duncan P. N. Exon Smith dexonsmith at apple.com
Tue Mar 17 10:31:54 PDT 2015


> On 2015-Mar-16, at 22:52, Duncan Exon Smith <dexonsmith at apple.com> wrote:
> 
> 
> On Mar 16, 2015, at 6:51 PM, David Blaikie <dblaikie at gmail.com> wrote:
> 
>> I'm all for it :)
> 
> Great!   I'll commit soon. 

r232505

> 
>> 
>> So this is enabled for any .ll file parsing? (I don't know exactly when/where the normal non-debug verifier is run)
> 
> There, and also in a number of spots in the optimization pipeline.  IIRC, the clang driver passes -disable-verify to -cc1 by default when you've built in Release mode to skip it. 
> 
>> 
>> On Mon, Mar 16, 2015 at 5:38 PM, Duncan P. N. Exon Smith <dexonsmith at apple.com> wrote:
>> r186634 started verifying debug info, and r194986 disabled it by default
>> because it was too expensive to run the checks on every function (since
>> most of the graph was reachable from each function).
>> 
>> r206300 moved the checks to module-level to make it cheaper, but there
>> was already quite a bit of testcase bitrot (and the verifier would only
>> print `<badref>`) so I guess no one had time to turn it back on.
>> 
>> This does just that.  Upgrade scripts this past autumn and winter
>> probably fixed some of the bitrot, and this weekend I fixed the verifier
>> output (r232275, r232417, r232418) and thusly the remaining failing
>> testcases (r232290, r232415).
>> 
>> 
>> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits





More information about the llvm-commits mailing list