[PATCH] [lld][Core] Implement parallel_for_each

Rui Ueyama ruiu at google.com
Mon Mar 16 13:31:39 PDT 2015


LGTM with this fix. Thank you for your patience. Let's give it a shot to see how it works.


================
Comment at: include/lld/Core/Parallel.h:299
@@ +298,3 @@
+  TaskGroup tg;
+  int64_t taskSize = 1024;
+  while (taskSize <= std::distance(begin, end)) {
----------------
I think int is enough, but if you choose other type, it should be ptrdiff_t instead of int64_t. (But, well, int should suffice.)

================
Comment at: include/lld/Core/Parallel.h:299
@@ +298,3 @@
+  TaskGroup tg;
+  int64_t taskSize = 1024;
+  while (taskSize <= std::distance(begin, end)) {
----------------
I think int is enough, but if you choose other type, it should be size_t and not int64_t.

http://reviews.llvm.org/D8348

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list