[lld] r232271 - Revert "[ELF] Change few static functions."

Shankar Easwaran shankare at codeaurora.org
Sat Mar 14 12:41:25 PDT 2015


Author: shankare
Date: Sat Mar 14 14:41:24 2015
New Revision: 232271

URL: http://llvm.org/viewvc/llvm-project?rev=232271&view=rev
Log:
Revert "[ELF] Change few static functions."

This reverts commit r232253.

Fix comments from dblaikie. Since these functions dont access member state, its ok to be static.

Modified:
    lld/trunk/lib/ReaderWriter/ELF/DefaultLayout.h
    lld/trunk/lib/ReaderWriter/ELF/OutputELFWriter.h

Modified: lld/trunk/lib/ReaderWriter/ELF/DefaultLayout.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/DefaultLayout.h?rev=232271&r1=232270&r2=232271&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/DefaultLayout.h (original)
+++ lld/trunk/lib/ReaderWriter/ELF/DefaultLayout.h Sat Mar 14 14:41:24 2015
@@ -193,7 +193,7 @@ public:
 
   /// \brief Returns true/false depending on whether the section has a Output
   //         segment or not
-  bool hasOutputSegment(Section<ELFT> *section);
+  static bool hasOutputSegment(Section<ELFT> *section);
 
   // Adds an atom to the section
   ErrorOr<const lld::AtomLayout *> addAtom(const Atom *atom) override;

Modified: lld/trunk/lib/ReaderWriter/ELF/OutputELFWriter.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/OutputELFWriter.h?rev=232271&r1=232270&r2=232271&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/OutputELFWriter.h (original)
+++ lld/trunk/lib/ReaderWriter/ELF/OutputELFWriter.h Sat Mar 14 14:41:24 2015
@@ -207,7 +207,7 @@ protected:
   /// @}
 
 private:
-  StringRef maybeGetSOName(Node *node);
+  static StringRef maybeGetSOName(Node *node);
 };
 
 //===----------------------------------------------------------------------===//
@@ -359,7 +359,7 @@ void OutputELFWriter<ELFT>::assignSectio
   _layout.assignFileOffsetsForMiscSections();
   for (auto sec : _layout.sections())
     if (auto section = dyn_cast<Section<ELFT>>(sec))
-      if (!_layout.hasOutputSegment(section))
+      if (!DefaultLayout<ELFT>::hasOutputSegment(section))
         _shdrtab->updateSection(section);
 }
 





More information about the llvm-commits mailing list