[PATCH] [lld][ELF] Ability to resolve undefined symbols lazily

Denis Protivensky dprotivensky at accesssoftek.com
Sat Mar 14 02:30:16 PDT 2015


================
Comment at: lib/ReaderWriter/ELF/ARM/ARMExecutableWriter.h:73
@@ +72,3 @@
+      gotAtom->_virtualAddr = gotpltSection->virtualAddr();
+    if (auto gotSection = _armLayout.findOutputSection(".got"))
+      gotAtom->_virtualAddr = gotSection->virtualAddr();
----------------
ruiu wrote:
> else if? The next line would override a result of one line above.
Ah, thanks, good catch!

================
Comment at: lib/ReaderWriter/ELF/OutputELFWriter.h:63
@@ +62,3 @@
+  DynamicSymbolFile(ELFLinkingContext &context, Resolver resolver)
+      : SimpleArchiveLibraryFile("Dynamic symbols for executable"),
+        _context(context), _resolver(resolver) {}
----------------
shankarke wrote:
> dynamic symbols for executable only ? I think this is applicable for shared libraries as well right ?
Right, will update it during commit.

http://reviews.llvm.org/D8159

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list