[PATCH] [CMake] Don't pass in MSVC warning flags as definitions

Greg Bedwell greg_bedwell at sn.scee.net
Fri Mar 13 12:02:33 PDT 2015


In http://reviews.llvm.org/D8188#140580, @rnk wrote:

> I think clang_compile only needs to pass down some of CMAKE_C_FLAGS in MSVC mode. For example, /D, /U, and /O2 are all translated correctly here. Other than those flags, I don't think it needs to do anything. Let me try to write a patch for that.


Ah, thanks!  I just created http://reviews.llvm.org/D8326 to filter out the above problematic flags (and would then make a small modification to this patch to use the '/flag' form for them here, but if you think a more general solution would be better I'm very happy to defer to you.

Thanks again!

-Greg


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D8188

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list