[PATCH] Add commit message guidelines to developer policy

hfinkel at anl.gov hfinkel at anl.gov
Fri Mar 13 06:09:12 PDT 2015


================
Comment at: docs/DeveloperPolicy.rst:299
@@ +298,3 @@
+* `Attribution of Changes`_ should be in a separate line, after the end of
+  the body, as simple as "Patch by John Doe.". This is how we officially
+  handle attribution, and there are automated processes that use that, so
----------------
dsanders wrote:
> rengolin wrote:
> > silvas wrote:
> > > Please use an exclamation mark like "Patch by John Doe!". For whatever reason this seems to be the way it is usually done. I also kind of like it because I think it expresses our excitement about committing the patch for a new contributor (new contributors are vital for community growth).
> > I never used the exclamation mark and I personally find it childish. But if everyone agrees we should keep it, I'll change it to it.
> I've never used it either, it's not a natural way for me to write. I think this is a individual personality thing and I don't think we should be codifying that.
I agree. I normally put something else afterward. I think just saying:

  Patch by <Name><Punctuation>.*

is the most we should do.

http://reviews.llvm.org/D8197

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list