[PATCH] [llvm-readobj] add support for macho universal binary
Chilledheart
rwindz0 at gmail.com
Thu Mar 12 19:13:37 PDT 2015
report error if any
================
Comment at: include/llvm/Object/MachOUniversal.h:113
@@ -109,1 +112,3 @@
+private:
+ std::vector<ObjectForArch> Objects;
};
----------------
rafael wrote:
> Please don't add this. You can use iterator_range to implement objects().
Thanks for pointing it out. It should be corrected in the next patch.
================
Comment at: tools/llvm-readobj/llvm-readobj.cpp:329
@@ +328,3 @@
+ if (ObjOrErr.getError())
+ continue;
+
----------------
rafael wrote:
> This now ignores every error. Shouldn't we call reportError for every error instead?
reportError code is added back
http://reviews.llvm.org/D8161
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list