[PATCHES] R600/SI: New V_FRACT fix, intrinsic for S_FLBIT_I32, and more

Marek Olšák maraeo at gmail.com
Thu Mar 12 08:48:34 PDT 2015


So can I consider that patches 2 & 3 have your "LGTM"?

Marek

On Tue, Mar 10, 2015 at 11:28 PM, Matt Arsenault
<Matthew.Arsenault at amd.com> wrote:
> On 03/10/2015 03:21 PM, Marek Olšák wrote:
>>
>> If we didn't have to deal with fsub, only one pattern would be needed.
>> A possible solution is to expand fsub, so that it's translated into
>> (v_add_f32 a, -b), and then convert it to v_sub_f32 in the shrinking
>> pass if it's possible.
>>
>> The hardware internally expands (v_sub_f32 a, b) into (v_add_f32 a, -b)
>> anyway.
>>
>> Marek
>
> When I removed the fsub pseudo, I was originally going to handle it with the
> expanded pattern, but then I noticed the expansion for fsub did the same
> thing anyway and was slightly easier. Another option might be to do that




More information about the llvm-commits mailing list