[PATCH] [llvm-readobj] add support for macho universal binary

Rafael Ávila de Espíndola rafael.espindola at gmail.com
Thu Mar 12 07:27:59 PDT 2015


================
Comment at: tools/llvm-readobj/llvm-readobj.cpp:326
@@ +325,3 @@
+static void dumpMachOUniversalBinary(const MachOUniversalBinary *UBinary) {
+  for (MachOUniversalBinary::object_iterator ObjI = UBinary->begin_objects(),
+                               ObjE = UBinary->end_objects();
----------------
Pity we don't have ' objects() to use with range loop. Would you mind adding it?

================
Comment at: tools/llvm-readobj/llvm-readobj.cpp:331
@@ +330,3 @@
+    if (std::error_code EC = ObjOrErr.getError()) {
+      // Ignore non-object files.
+      if (EC != object_error::invalid_file_type)
----------------
Why? Do we really get universal binaries with non Object Members?

http://reviews.llvm.org/D8161

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list