Seems fine to me, but I would be happier if somebody else can take a look as well (also the semantic action). http://reviews.llvm.org/D8271 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/