[PATCH] LinkerScript: Add parsing of the EXTERN command

Davide Italiano davide at freebsd.org
Wed Mar 11 15:27:07 PDT 2015


I see no problems with the patch as-is, but I'm more and more concerned about the direction LinkerScript is taking. 
It seems like we keep adding support for parsing of different directives without implementing the corresponding semantic action, so this is almost-dead code.
In order to not have this gap growing I propose that at least for new directives we implement both semantic and parsing action at the same time, even in two different patches to facilitate review.


http://reviews.llvm.org/D8271

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list