[PATCH] Allow the specification of a "mode" property on the LLDB Builder

Galina gkistanova at gmail.com
Wed Mar 11 15:16:18 PDT 2015


No. Not really.
If I get what you are after, you need something like this:

from buildbot.process.properties import WithProperties, Property
...
SVN(...

  mode=Property('mode', default=svnMode),
  ...)

And frankly, I'd rename 'svnMode' to just 'mode' to keep the naming consistent. Also please note that user provided mode would be passing through to the SVN object, so you might want to sanitize the values before calling SVN.


http://reviews.llvm.org/D8062

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list