[PATCH] [lld][ELF] Ability to resolve undefined symbols lazily

Rui Ueyama ruiu at google.com
Wed Mar 11 12:03:32 PDT 2015


LGTM


================
Comment at: lib/ReaderWriter/ELF/ARM/ARMExecutableWriter.h:73
@@ +72,3 @@
+      gotAtom->_virtualAddr = gotpltSection->virtualAddr();
+    if (auto gotSection = _armLayout.findOutputSection(".got"))
+      gotAtom->_virtualAddr = gotSection->virtualAddr();
----------------
else if? The next line would override a result of one line above.

http://reviews.llvm.org/D8159

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list