[patch][R600] Call EmitFunctionHeader just before EmitFunctionBody.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Wed Mar 11 11:49:46 PDT 2015


Hi Tom,

Currently R600 is the only backend whose call to EmitFunctionHeader is
not just before EmitFunctionBody. Looking at the code history I think
this is an unintended consequence from when R600 had a more custom
syntax and didn't even call EmitFunctionHeader.

The attached t1.patch changes that and updates the tests to check for
the new order.

The reason for doing so is that it allows EmitFunctionHeader to be
just a private helper (see t2.patch) which reduces code duplication
and helps with another patch I am working on.

Cheers,
Rafael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: t1.patch
Type: text/x-patch
Size: 5664 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150311/1279b04b/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: t2.patch
Type: text/x-patch
Size: 2971 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150311/1279b04b/attachment-0001.bin>


More information about the llvm-commits mailing list