[PATCH] Move the DataLayout to the generic TargetMachine, making it mandatory.

Mehdi Amini mehdi.amini at apple.com
Wed Mar 11 07:50:25 PDT 2015


Yes, I see this as an intermediate step. In my mind, having a single point where the DataLayout is stored makes it easier to think about how to change it now.

There should be only two DataLayout object now: one in the Module, and one on the TargetMachine (I nuked the TargetLoweringInfo in an earlier patch).

— 
Mehdi

> On Mar 10, 2015, at 11:51 PM, Eric Christopher <echristo at gmail.com> wrote:
> 
> Seems reasonable. Vaguely unhappy with the string option for target machine - I'd rather it just be grabbed from the module and stored somewhere. That said this is a nice intermediate step at least.
> 
> -eric
> 
> 
> http://reviews.llvm.org/D8243
> 
> EMAIL PREFERENCES
>  http://reviews.llvm.org/settings/panel/emailpreferences/
> 
> 





More information about the llvm-commits mailing list