Patch looks fine to me other than my one comment. But I've never really looked at this file so I'm not sure I'm the best reviewer. http://reviews.llvm.org/D8184 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/