[PATCH] [zorg] add llgo builder, osuosl config

Galina gkistanova at gmail.com
Tue Mar 10 19:32:47 PDT 2015


Thanks for working on this, Andrew!

You may want to consider clean builds as well as incremental builds supported now.
In this case, you would need to support at least a 'clean' property and add a step to remove the llvm_objdir with all the content if the property is set (by using the doStepIf param). This is not a show stopper for this patch, though.


================
Comment at: zorg/buildbot/builders/LLGoBuilder.py:24
@@ +23,3 @@
+    f.addStep(buildbot.steps.shell.SetProperty(name="get_builddir",
+                                               command=["pwd"],
+                                               property="builddir",
----------------
You import from buildbot.steps.shell, why not import SetProperty there as well?


================
Comment at: zorg/buildbot/builders/LLGoBuilder.py:65
@@ +64,3 @@
+                               command=["ninja", "llgo"],
+                               haltOnFailure=True,
+                               description=["build llgo"],
----------------
Could you use NinjaCommand instead of direct invoking ShellCommand with "ninja" here and below, please?

http://reviews.llvm.org/D7989

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list