[PATCH] Fix the problem that the last test failure not always displayed on test summary page for LitTestCommand

Siva Chandra sivachandra at google.com
Tue Mar 10 18:08:51 PDT 2015


LGTM with nits. Assuming you have tested all possible builder outputs.


================
Comment at: zorg/buildbot/commands/LitTestCommand.py:38
@@ -37,2 +37,3 @@
     # Current line will be parsed as result steps only if parserStarted is True
     self.parserStarted = not parseSummaryOnly
+    self.summaryLine = False
----------------
I think you can remove this, but can be done on another day.

================
Comment at: zorg/buildbot/commands/LitTestCommand.py:39
@@ -38,2 +38,3 @@
     self.parserStarted = not parseSummaryOnly
+    self.summaryLine = False
 
----------------
nit: s/summaryLine/summaryStarted

================
Comment at: zorg/buildbot/commands/LitTestCommand.py:79
@@ -77,1 +78,3 @@
 
+  def summaryLineReceived(self, line):
+    # Check for test status line
----------------
nit: s/summaryLineReceived/handleTestResultLine

http://reviews.llvm.org/D8229

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list