[PATCH] Fix the problem that the last test failure not always displayed on test summary page for LitTestCommand

[Siva Chandra]

================
Comment at: zorg/buildbot/commands/LitTestCommand.py:77
@@ -73,2 +76,3 @@
+        self.numLogs += 1
 
     # Reset the current state.
----------------
I think you can refactor this logic of handling verbose logs by using "Failing Tests" as an indicator. That is, if you hit "Failing Tests" before you see any failures, assume that there will be no verbose logs. If you see failing tests before you see "Failing Tests", then there could be verbose logs and so look for them.

================
Comment at: zorg/buildbot/commands/LitTestCommand.py:99
@@ -95,9 +98,3 @@
 
-    # Otherwise, if we had any previous test consider it finished.
-    #
-    # FIXME: This assumes that we will always have at least one line following
-    # the last test result to properly record each test; we could fix this if
-    # buildbot provided us a hook for when the log is done.
-    if self.lastTestResult:
-      self.testInfoFinished()
+    self.lastTestResult = None
 
----------------
I think you dont need this anymore. 

================
Comment at: zorg/buildbot/commands/LitTestCommand.py:114
@@ -116,2 +113,3 @@
+        self.testInfoFinished()
         return
 
----------------
I think to increase readability here, you should move lines 104-114 to line 99. But, this might look different after the refactoring suggested above.

http://reviews.llvm.org/D8229

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/